-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-48141][TEST] Update the Oracle docker image version used for test and integration to use Oracle Database 23ai Free #46399
Conversation
…to use Oracle Database 23ai Free
Also cc @gvenzl from gvenzl/oci-oracle-free#35 (comment) |
.github/workflows/build_and_test.yml
Outdated
@@ -929,7 +929,7 @@ jobs: | |||
HIVE_PROFILE: hive2.3 | |||
GITHUB_PREV_SHA: ${{ github.event.before }} | |||
SPARK_LOCAL_IP: localhost | |||
ORACLE_DOCKER_IMAGE_NAME: gvenzl/oracle-free:23.3 | |||
ORACLE_DOCKER_IMAGE_NAME: gvenzl/oracle-free:23.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we remove this because we don't need this env variable, @LucaCanali and @yaooqinn ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sys.env.getOrElse("ORACLE_DOCKER_IMAGE_NAME", "gvenzl/oracle-free:23.4-slim")
is enough, isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, if this PR affects old release branch's test coverage due to .github/workflows/build_and_test.yml
change, it would be very weird. What fixed versions should we use for SPARK-48141?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for removal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. (I removed the line)
Merged to master for Apache Spark 4.0.0-preview.
Thank you, @LucaCanali and @yaooqinn .
Thank you @dongjoon-hyun and @yaooqinn |
…est and integration to use Oracle Database 23ai Free ### What changes were proposed in this pull request? This proposes to update the Docker image used for integration tests and builds to Oracle Database 23ai Free, version 23.4 (previously we used Oracle Database 23c Free, version 23.3) ### Why are the changes needed? This is to keep the testing infrastructure up-to-date with the latest Oracle Database Free version. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing test infrastructure. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#46399 from LucaCanali/updateOracleImage. Lead-authored-by: Luca Canali <[email protected]> Co-authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
What changes were proposed in this pull request?
This proposes to update the Docker image used for integration tests and builds to Oracle Database 23ai Free, version 23.4 (previously we used Oracle Database 23c Free, version 23.3)
Why are the changes needed?
This is to keep the testing infrastructure up-to-date with the latest Oracle Database Free version.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing test infrastructure.
Was this patch authored or co-authored using generative AI tooling?
No